fix: guard null failure_reason render, fix mid-quality test description

- Add v-if guard on failure-reason <p> so null renders no element (not literal "null")
- Clarify mid-quality test description: score is 0.4 to <0.7 (exclusive upper bound)
- Add test: renders nothing for failure_reason when null (+1 → 14 SftCard tests)
This commit is contained in:
pyr0ball 2026-04-08 15:23:19 -07:00
parent e16ea95dcc
commit 03e5f9f9b4
2 changed files with 8 additions and 2 deletions

View file

@ -52,7 +52,7 @@ describe('SftCard', () => {
expect(w.find('[data-testid="quality-chip"]').classes()).toContain('quality-low')
})
it('quality chip has mid-quality class when score 0.4-0.7', () => {
it('quality chip has mid-quality class when score is 0.4 to <0.7', () => {
const w = mount(SftCard, { props: { item: MID_QUALITY_ITEM } })
expect(w.find('[data-testid="quality-chip"]').classes()).toContain('quality-mid')
})
@ -89,4 +89,10 @@ describe('SftCard', () => {
const w = mount(SftCard, { props: { item: LOW_QUALITY_ITEM, correcting: true } })
expect(w.find('[data-testid="correction-area"]').exists()).toBe(true)
})
it('renders nothing for failure reason when null', () => {
const item = { ...LOW_QUALITY_ITEM, failure_reason: null }
const w = mount(SftCard, { props: { item } })
expect(w.find('.failure-reason').exists()).toBe(false)
})
})

View file

@ -17,7 +17,7 @@
</div>
<!-- Failure reason -->
<p class="failure-reason">{{ item.failure_reason }}</p>
<p v-if="item.failure_reason" class="failure-reason">{{ item.failure_reason }}</p>
<!-- Prompt (collapsible) -->
<div class="prompt-section">