pyr0ball
f3bc796f2c
Replace hand-rolled feedback.py with make_feedback_router() from circuitforge_core.api.feedback. Update tests to mount the shared router on a minimal FastAPI app and mock at the core module level.
138 lines
4.9 KiB
Python
138 lines
4.9 KiB
Python
"""Tests for the shared feedback router (circuitforge-core) mounted in kiwi."""
|
|
from __future__ import annotations
|
|
|
|
from collections.abc import Callable
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from fastapi import FastAPI
|
|
from fastapi.testclient import TestClient
|
|
|
|
from circuitforge_core.api.feedback import make_feedback_router
|
|
|
|
|
|
# ── Test app factory ──────────────────────────────────────────────────────────
|
|
|
|
def _make_client(demo_mode_fn: Callable[[], bool] | None = None) -> TestClient:
|
|
app = FastAPI()
|
|
router = make_feedback_router(
|
|
repo="Circuit-Forge/kiwi",
|
|
product="kiwi",
|
|
demo_mode_fn=demo_mode_fn,
|
|
)
|
|
app.include_router(router, prefix="/api/v1/feedback")
|
|
return TestClient(app)
|
|
|
|
|
|
# ── /api/v1/feedback/status ───────────────────────────────────────────────────
|
|
|
|
def test_status_disabled_when_no_token(monkeypatch):
|
|
monkeypatch.delenv("FORGEJO_API_TOKEN", raising=False)
|
|
monkeypatch.delenv("DEMO_MODE", raising=False)
|
|
client = _make_client(demo_mode_fn=lambda: False)
|
|
res = client.get("/api/v1/feedback/status")
|
|
assert res.status_code == 200
|
|
assert res.json() == {"enabled": False}
|
|
|
|
|
|
def test_status_enabled_when_token_set(monkeypatch):
|
|
monkeypatch.setenv("FORGEJO_API_TOKEN", "test-token")
|
|
client = _make_client(demo_mode_fn=lambda: False)
|
|
res = client.get("/api/v1/feedback/status")
|
|
assert res.status_code == 200
|
|
assert res.json() == {"enabled": True}
|
|
|
|
|
|
def test_status_disabled_in_demo_mode(monkeypatch):
|
|
monkeypatch.setenv("FORGEJO_API_TOKEN", "test-token")
|
|
demo = True
|
|
client = _make_client(demo_mode_fn=lambda: demo)
|
|
res = client.get("/api/v1/feedback/status")
|
|
assert res.status_code == 200
|
|
assert res.json() == {"enabled": False}
|
|
|
|
|
|
# ── POST /api/v1/feedback ─────────────────────────────────────────────────────
|
|
|
|
def test_submit_returns_503_when_no_token(monkeypatch):
|
|
monkeypatch.delenv("FORGEJO_API_TOKEN", raising=False)
|
|
client = _make_client(demo_mode_fn=lambda: False)
|
|
res = client.post("/api/v1/feedback", json={
|
|
"title": "Test", "description": "desc", "type": "bug",
|
|
})
|
|
assert res.status_code == 503
|
|
|
|
|
|
def test_submit_returns_403_in_demo_mode(monkeypatch):
|
|
monkeypatch.setenv("FORGEJO_API_TOKEN", "test-token")
|
|
demo = False
|
|
client = _make_client(demo_mode_fn=lambda: demo)
|
|
|
|
# Confirm non-demo path isn't 403 (sanity), then flip demo flag
|
|
demo = True
|
|
client2 = _make_client(demo_mode_fn=lambda: demo)
|
|
res = client2.post("/api/v1/feedback", json={
|
|
"title": "Test", "description": "desc", "type": "bug",
|
|
})
|
|
assert res.status_code == 403
|
|
|
|
|
|
def test_submit_creates_issue(monkeypatch):
|
|
monkeypatch.setenv("FORGEJO_API_TOKEN", "test-token")
|
|
|
|
label_response = MagicMock()
|
|
label_response.ok = True
|
|
label_response.json.return_value = [
|
|
{"id": 1, "name": "beta-feedback"},
|
|
{"id": 2, "name": "needs-triage"},
|
|
{"id": 3, "name": "bug"},
|
|
]
|
|
|
|
issue_response = MagicMock()
|
|
issue_response.ok = True
|
|
issue_response.json.return_value = {
|
|
"number": 42,
|
|
"html_url": "https://example.com/issues/42",
|
|
}
|
|
|
|
client = _make_client(demo_mode_fn=lambda: False)
|
|
|
|
with patch("circuitforge_core.api.feedback.requests.get", return_value=label_response), \
|
|
patch("circuitforge_core.api.feedback.requests.post", return_value=issue_response):
|
|
res = client.post("/api/v1/feedback", json={
|
|
"title": "Something broke",
|
|
"description": "It broke when I tapped X",
|
|
"type": "bug",
|
|
"repro": "1. Open app\n2. Tap X",
|
|
"tab": "pantry",
|
|
})
|
|
|
|
assert res.status_code == 200
|
|
data = res.json()
|
|
assert data["issue_number"] == 42
|
|
assert data["issue_url"] == "https://example.com/issues/42"
|
|
|
|
|
|
def test_submit_returns_502_on_forgejo_error(monkeypatch):
|
|
monkeypatch.setenv("FORGEJO_API_TOKEN", "test-token")
|
|
|
|
label_response = MagicMock()
|
|
label_response.ok = True
|
|
label_response.json.return_value = [
|
|
{"id": 1, "name": "beta-feedback"},
|
|
{"id": 2, "name": "needs-triage"},
|
|
{"id": 3, "name": "question"},
|
|
]
|
|
|
|
bad_response = MagicMock()
|
|
bad_response.ok = False
|
|
bad_response.text = "forbidden"
|
|
|
|
client = _make_client(demo_mode_fn=lambda: False)
|
|
|
|
with patch("circuitforge_core.api.feedback.requests.get", return_value=label_response), \
|
|
patch("circuitforge_core.api.feedback.requests.post", return_value=bad_response):
|
|
res = client.post("/api/v1/feedback", json={
|
|
"title": "Oops", "description": "desc", "type": "other",
|
|
})
|
|
|
|
assert res.status_code == 502
|