Circuit-Forge/peregrine
2
0
Fork 0
Code Issues 22 Pull requests 2 Projects Releases 6 Packages Wiki Activity Actions

fix: save form data to non-widget state on Next, fix disabled timing, pass page title

Browse source
This commit is contained in:
pyr0ball 2026-03-03 15:17:45 -08:00
parent 042bb519de
commit 1c7980cc78
2 changed files with 23 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/app.py
View file

@ -165,6 +165,6 @@ with st.sidebar:
_task_indicator() _task_indicator()
st.divider() st.divider()
st.caption(f"Peregrine {_get_version()}") st.caption(f"Peregrine {_get_version()}")
inject_feedback_button() inject_feedback_button(page=pg.title)
pg.run() pg.run()

33
app/feedback.py
View file

@ -73,14 +73,21 @@ def _feedback_dialog(page: str) -> None:
_clear_feedback_state() _clear_feedback_state()
st.rerun() # intentionally closes the dialog st.rerun() # intentionally closes the dialog
with col_next: with col_next:
if st.button( if st.button("Next →", type="primary"):
"Next →", # Read widget values NOW (same rerun as the click — values are
type="primary", # available here even on first click). Copy to non-widget keys
disabled=not st.session_state.get("fb_title", "").strip() # so they survive step 2's render (Streamlit removes widget
or not st.session_state.get("fb_desc", "").strip(), # state for widgets that are no longer rendered).
): title = fb_title.strip()
desc = fb_desc.strip()
if not title or not desc:
st.error("Please fill in both Title and Description.")
else:
st.session_state.fb_data_type = fb_type
st.session_state.fb_data_title = title
st.session_state.fb_data_desc = desc
st.session_state.fb_data_repro = st.session_state.get("fb_repro", "")
st.session_state.fb_step = 2 st.session_state.fb_step = 2
# no st.rerun() — button click already re-renders the dialog
# ═════════════════════════════════════════════════════════════════════════ # ═════════════════════════════════════════════════════════════════════════
# STEP 2 — Consent + attachments # STEP 2 — Consent + attachments
@ -178,7 +185,7 @@ def _submit(page, include_diag, submitter, collect_context, collect_logs,
if submitter: if submitter:
attachments["submitter"] = submitter attachments["submitter"] = submitter
fb_type = st.session_state.get("fb_type", "Other") fb_type = st.session_state.get("fb_data_type", "Other")
type_key = {"Bug": "bug", "Feature Request": "feature", "Other": "other"}.get( type_key = {"Bug": "bug", "Feature Request": "feature", "Other": "other"}.get(
fb_type, "other" fb_type, "other"
) )
@ -189,15 +196,15 @@ def _submit(page, include_diag, submitter, collect_context, collect_logs,
form = { form = {
"type": type_key, "type": type_key,
"description": st.session_state.get("fb_desc", ""), "description": st.session_state.get("fb_data_desc", ""),
"repro": st.session_state.get("fb_repro", "") if type_key == "bug" else "", "repro": st.session_state.get("fb_data_repro", "") if type_key == "bug" else "",
} }
body = build_issue_body(form, context, attachments) body = build_issue_body(form, context, attachments)
try: try:
result = create_forgejo_issue( result = create_forgejo_issue(
st.session_state.get("fb_title", "Feedback"), body, labels st.session_state.get("fb_data_title", "Feedback"), body, labels
) )
screenshot = st.session_state.get("fb_screenshot") screenshot = st.session_state.get("fb_screenshot")
if screenshot: if screenshot:
@ -213,7 +220,9 @@ def _submit(page, include_diag, submitter, collect_context, collect_logs,
def _clear_feedback_state() -> None: def _clear_feedback_state() -> None:
for key in [ for key in [
"fb_step", "fb_type", "fb_title", "fb_desc", "fb_repro", "fb_step",
"fb_type", "fb_title", "fb_desc", "fb_repro", # widget keys
"fb_data_type", "fb_data_title", "fb_data_desc", "fb_data_repro", # saved data
"fb_diag", "fb_upload", "fb_attr", "fb_screenshot", "fb_paste_key", "fb_diag", "fb_upload", "fb_attr", "fb_screenshot", "fb_paste_key",
]: ]:
st.session_state.pop(key, None) st.session_state.pop(key, None)