From aa92bc1e5b028f945f2a17ebf88f0676f4718c57 Mon Sep 17 00:00:00 2001 From: pyr0ball Date: Tue, 17 Mar 2026 20:33:55 -0700 Subject: [PATCH] fix(tests): update mock from inner_text() to text_content() in e2e helpers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit get_page_errors() was switched to text_content() to capture errors in CSS-hidden elements (collapsed Streamlit expanders). Two unit test mocks still stubbed inner_text() — causing CI failures because MagicMock() returned a non-string from text_content(), breaking the "boom" in message content assertion. --- tests/test_e2e_helpers.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/test_e2e_helpers.py b/tests/test_e2e_helpers.py index 4b6dd79..2a38d4a 100644 --- a/tests/test_e2e_helpers.py +++ b/tests/test_e2e_helpers.py @@ -116,8 +116,7 @@ def test_get_page_errors_finds_exceptions(monkeypatch): from tests.e2e.conftest import get_page_errors mock_el = MagicMock() - mock_el.get_attribute.return_value = None - mock_el.inner_text.return_value = "RuntimeError: boom" + mock_el.text_content.return_value = "RuntimeError: boom" mock_el.inner_html.return_value = "
RuntimeError: boom
" mock_page = MagicMock() @@ -138,7 +137,7 @@ def test_get_page_errors_finds_alert_errors(monkeypatch): mock_child = MagicMock() mock_el = MagicMock() mock_el.query_selector.return_value = mock_child - mock_el.inner_text.return_value = "Something went wrong" + mock_el.text_content.return_value = "Something went wrong" mock_el.inner_html.return_value = "
Something went wrong
" mock_page = MagicMock()