From cddb2b64191565141038dca0fc47bbca7db37a9b Mon Sep 17 00:00:00 2001 From: pyr0ball Date: Tue, 3 Mar 2026 13:28:26 -0800 Subject: [PATCH] =?UTF-8?q?fix:=20remove=20st.rerun()=20from=20dialog=20na?= =?UTF-8?q?v=20buttons=20=E2=80=94=20caused=20dialog=20to=20close=20on=20N?= =?UTF-8?q?ext/Back?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- app/feedback.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/feedback.py b/app/feedback.py index 0d64607..1267e13 100644 --- a/app/feedback.py +++ b/app/feedback.py @@ -72,7 +72,7 @@ def _feedback_dialog(page: str) -> None: with col_cancel: if st.button("Cancel"): _clear_feedback_state() - st.rerun() + st.rerun() # intentionally closes the dialog with col_next: if st.button( "Next →", @@ -81,7 +81,7 @@ def _feedback_dialog(page: str) -> None: or not st.session_state.get("fb_desc", "").strip(), ): st.session_state.fb_step = 2 - st.rerun() + # no st.rerun() — button click already re-renders the dialog # ═════════════════════════════════════════════════════════════════════════ # STEP 2 — Consent + attachments @@ -136,7 +136,7 @@ def _feedback_dialog(page: str) -> None: ) if st.button("🗑 Remove screenshot"): st.session_state.pop("fb_screenshot", None) - st.rerun() + # no st.rerun() — button click already re-renders the dialog # ── Attribution consent ─────────────────────────────────────────────── st.divider() @@ -159,7 +159,7 @@ def _feedback_dialog(page: str) -> None: with col_back: if st.button("← Back"): st.session_state.fb_step = 1 - st.rerun() + # no st.rerun() — button click already re-renders the dialog with col_submit: if st.button("Submit Feedback", type="primary"):