snipe/tests/trust/test_aggregator.py

from app.db.models import Seller
from app.trust.aggregator import Aggregator


def test_composite_sum_of_five_signals():
    agg = Aggregator()
    scores = {
        "account_age": 18, "feedback_count": 16,
        "feedback_ratio": 20, "price_vs_market": 15,
        "category_history": 14,
    }
    result = agg.aggregate(scores, photo_hash_duplicate=False, seller=None)
    assert result.composite_score == 83


def test_hard_filter_new_account():
    agg = Aggregator()
    scores = {k: 20 for k in ["account_age", "feedback_count",
                               "feedback_ratio", "price_vs_market", "category_history"]}
    young_seller = Seller(
        platform="ebay", platform_seller_id="u", username="u",
        account_age_days=3, feedback_count=0,
        feedback_ratio=1.0, category_history_json="{}",
    )
    result = agg.aggregate(scores, photo_hash_duplicate=False, seller=young_seller)
    assert "new_account" in result.red_flags_json


def test_hard_filter_bad_actor_established_account():
    """Established account (count > 20) with very bad ratio → hard filter."""
    agg = Aggregator()
    scores = {k: 10 for k in ["account_age", "feedback_count",
                               "feedback_ratio", "price_vs_market", "category_history"]}
    bad_seller = Seller(
        platform="ebay", platform_seller_id="u", username="u",
        account_age_days=730, feedback_count=25,  # count > 20
        feedback_ratio=0.70,                       # ratio < 80% → hard filter
        category_history_json="{}",
    )
    result = agg.aggregate(scores, photo_hash_duplicate=False, seller=bad_seller)
    assert "established_bad_actor" in result.red_flags_json


def test_partial_score_flagged_when_signals_missing():
    agg = Aggregator()
    scores = {
        "account_age": 18, "feedback_count": None,  # None = unavailable
        "feedback_ratio": 20, "price_vs_market": 15,
        "category_history": 14,
    }
    result = agg.aggregate(scores, photo_hash_duplicate=False, seller=None)
    assert result.score_is_partial is True


def test_suspicious_price_not_flagged_when_market_data_absent():
    """None price_vs_market (no market comp) must NOT trigger suspicious_price.

    Regression guard: clean[] replaces None with 0, so naive `clean[...] == 0`
    would fire even when the signal is simply unavailable.
    """
    agg = Aggregator()
    scores = {
        "account_age": 15, "feedback_count": 15,
        "feedback_ratio": 20, "price_vs_market": None,  # no market data
        "category_history": 0,
    }
    result = agg.aggregate(scores, photo_hash_duplicate=False, seller=None)
    assert "suspicious_price" not in result.red_flags_json


def test_suspicious_price_flagged_when_price_genuinely_low():
    """price_vs_market == 0 (explicitly, meaning >50% below median) → flag fires."""
    agg = Aggregator()
    scores = {
        "account_age": 15, "feedback_count": 15,
        "feedback_ratio": 20, "price_vs_market": 0,  # price is scam-level low
        "category_history": 0,
    }
    result = agg.aggregate(scores, photo_hash_duplicate=False, seller=None)
    assert "suspicious_price" in result.red_flags_json


def test_scratch_dent_flagged_from_title_slash_variant():
    """Title containing 'parts/repair' (slash variant, no 'or') must trigger scratch_dent_mentioned."""
    agg = Aggregator()
    scores = {k: 15 for k in ["account_age", "feedback_count",
                               "feedback_ratio", "price_vs_market", "category_history"]}
    result = agg.aggregate(
        scores, photo_hash_duplicate=False, seller=None,
        listing_title="Generic Widget XL - Parts/Repair",
    )
    assert "scratch_dent_mentioned" in result.red_flags_json


def test_scratch_dent_flagged_from_condition_field():
    """eBay formal condition 'for parts or not working' must trigger scratch_dent_mentioned
    even when the listing title contains no damage keywords."""
    agg = Aggregator()
    scores = {k: 15 for k in ["account_age", "feedback_count",
                               "feedback_ratio", "price_vs_market", "category_history"]}
    result = agg.aggregate(
        scores, photo_hash_duplicate=False, seller=None,
        listing_title="Generic Widget XL",
        listing_condition="for parts or not working",
    )
    assert "scratch_dent_mentioned" in result.red_flags_json


def test_scratch_dent_not_flagged_for_clean_listing():
    """Clean title + 'New' condition must NOT trigger scratch_dent_mentioned."""
    agg = Aggregator()
    scores = {k: 15 for k in ["account_age", "feedback_count",
                               "feedback_ratio", "price_vs_market", "category_history"]}
    result = agg.aggregate(
        scores, photo_hash_duplicate=False, seller=None,
        listing_title="Generic Widget XL",
        listing_condition="new",
    )
    assert "scratch_dent_mentioned" not in result.red_flags_json


def test_new_account_not_flagged_when_age_absent():
    """account_age_days=None (scraper tier) must NOT trigger new_account or account_under_30_days."""
    agg = Aggregator()
    scores = {k: 10 for k in ["account_age", "feedback_count",
                               "feedback_ratio", "price_vs_market", "category_history"]}
    scraper_seller = Seller(
        platform="ebay", platform_seller_id="u", username="u",
        account_age_days=None,  # not fetched at scraper tier
        feedback_count=50, feedback_ratio=0.99, category_history_json="{}",
    )
    result = agg.aggregate(scores, photo_hash_duplicate=False, seller=scraper_seller)
    assert "new_account" not in result.red_flags_json
    assert "account_under_30_days" not in result.red_flags_json