Circuit-Forge/turnstone
5
0
Fork 0
Code Issues 11 Pull requests 1 Projects Releases 6 Packages Wiki Activity Actions

fix: move format_context_block() call inside legacy-only branch in diagnose/__init__.py #37

New issue
Closed
opened 2026-05-25 18:58:34 -07:00 by pyr0ball · 0 comments
pyr0ball commented 2026-05-25 18:58:34 -07:00
Owner
Copy link

Context

In app/services/diagnose/__init__.py, format_context_block(ctx) is called unconditionally, but context_block is only used in the legacy LLM path. When MULTI_AGENT_ENABLED=True, the call is a no-op waste.

Fix

Move the context_block = format_context_block(ctx) assignment inside the else: branch (the legacy path).

Found by

Post-implementation code review of feat/29-multi-agent-diagnose.

## Context In `app/services/diagnose/__init__.py`, `format_context_block(ctx)` is called unconditionally, but `context_block` is only used in the legacy LLM path. When `MULTI_AGENT_ENABLED=True`, the call is a no-op waste. ## Fix Move the `context_block = format_context_block(ctx)` assignment inside the `else:` branch (the legacy path). ## Found by Post-implementation code review of feat/29-multi-agent-diagnose.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
feat/42-50-postgres-multitenant
feat/32-domain-view
feat/15-hybrid-rag
feat/41-hybrid-bert-shim
feat/60-incidents-db
feat/pipeline-cleanup
feat/29-multi-agent-diagnose
feat/ssh-remote-glean
feat/live-watch
feat/llm-reasoning
feat/frictionless-capture
v0.7.0
v0.6.2
v0.6.1
v0.6.0
v0.5.0
v0.4.0
v0.3.0
v0.2.0
v0.1.0
Labels
Clear labels   
compliance

   
demo

   
deployment

   
docs

   
enhancement

   
parser

   
patterns

   
performance

   
security

   
ux
No labels
compliance
demo
deployment
docs
enhancement
parser
patterns
performance
security
ux
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Circuit-Forge/turnstone#37
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?