havoc-remaster/tools/havoc_mcp_server.py
pyr0ball 7d39ccddf0 fix: harden debug agent for reliable WOW64 watchpoints and multi-run stability
Key fixes applied during Task 6 end-to-end MCP integration testing:

- CONTEXT_ALL (CONTEXT_FULL | CONTEXT_DEBUG_REGISTERS) for Wow64Get/SetThreadContext
  so DR0-DR7 are read and written alongside general-purpose registers
- Native x64 SetThreadContext path in _apply_watchpoints_to_thread: Wow64SetThreadContext
  updates the WOW64 context save area but does not propagate to hardware DR registers;
  the native path is required for hardware watchpoints to actually fire on WOW64 threads
- _REGISTER_NAMES extended to include Dr0-Dr3, Dr6, Dr7 so get_registers returns them
- launch() now terminates and drains the previously attached process before starting a
  new one, preventing stale debug events from a hung game from corrupting a new session
- continue_execution filters events by process ID so late-arriving exit events from a
  previously terminated game do not trigger a false "exited" status for the new process
- AV exception routing restored: EXCEPTION_ACCESS_VIOLATION stops and reports; callers
  skip boot-time AVs in a loop rather than silently continuing them in the agent
- launch_with_breakpoints atomic op in agent server and MCP server
- _DebugWorker dedicated thread: Windows debug API requires all WaitForDebugEvent,
  ContinueDebugEvent, and CreateProcessA calls to originate from the same OS thread;
  ThreadingTCPServer violated this -- replaced with single worker thread + queue
- Gameplay screenshot captured at watchpoint stop (272 KB real frame)

Acceptance checklist results:
- Item 1 PASS: bp@0x40C8E0, eip/eax confirmed
- Item 2 PASS: conditional breakpoint false-skip and true-fire verified
- Item 3 PASS: watchpoint@slot0 fired at 0x40E998 (MOV [DAT_0047c488], EAX in
  player_cooldown_timers_tick -- the DAT write is in the caller, not inside
  compute_frame_delta_ticks_60hz_min1_clamp as the spec assumed)
- Item 4 PASS: screenshot PNG captured (gameplay frame 272 KB)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TN4Ytn3gdWRonNmHpisWQv
2026-07-04 14:05:24 -07:00

181 lines
6.6 KiB
Python

"""Thin MCP server translating MCP tool calls into calls to the local debug agent.
No Win32/ctypes dependency of its own -- runs and is tested on any platform, though at
runtime it must reach the real debug agent server (tools/havoc_debug_agent_server.py)
running on the same Caspian box."""
from __future__ import annotations
import hmac
import os
import socket
from starlette.responses import PlainTextResponse
from tools.havoc_debug_protocol import decode_message, encode_message
class DebugAgentError(Exception):
"""Raised when the debug agent reports {"ok": false}."""
class DebugAgentClient:
def __init__(self, host: str, port: int) -> None:
self._host = host
self._port = port
def call(self, op: str, params: dict) -> dict:
with socket.create_connection((self._host, self._port), timeout=60) as sock:
sock.sendall(encode_message(op, params))
buf = b""
while not buf.endswith(b"\n"):
chunk = sock.recv(65536)
if not chunk:
break
buf += chunk
response = decode_message(buf)
if not response.get("ok"):
raise DebugAgentError(response.get("error", "unknown debug agent error"))
return response.get("result", {})
def check_bearer_token(header_value: str | None, expected: str) -> bool:
if not expected:
return False
if header_value is None:
return False
prefix = "Bearer "
if not header_value.startswith(prefix):
return False
return hmac.compare_digest(header_value[len(prefix):], expected)
# --- MCP tool wiring (mcp SDK 1.28.1) --------------------------------------------
#
# FastMCP.tool() is a plain decorator: `@mcp.tool()` registers the wrapped function,
# using its name, type hints, and docstring to build the tool's JSON schema -- this
# matches the brief's example code as-is under the installed SDK version.
#
# FastMCP's own built-in auth (`mcp.server.auth`, `AuthSettings`, `TokenVerifier`) is a
# full OAuth2-resource-server flow (issuer URLs, scopes, token introspection) meant for
# public/multi-tenant deployments. That is the wrong shape for this tool: a single
# shared secret guarding one LAN-only debug endpoint. So `check_bearer_token` is instead
# wired in below `FastMCP`, as a raw ASGI middleware placed in front of the Starlette
# app that `FastMCP.streamable_http_app()` returns -- every HTTP request is checked
# there before it ever reaches the MCP session manager.
from mcp.server.fastmcp import FastMCP
def build_mcp_server(client: DebugAgentClient) -> FastMCP:
mcp = FastMCP("havoc-runtime-observation")
@mcp.tool()
def launch(path: str, cwd: str) -> dict:
return client.call("launch", {"path": path, "cwd": cwd})
@mcp.tool()
def launch_with_breakpoints(path: str, cwd: str, breakpoints: list) -> dict:
"""Launch the game and plant INT3 breakpoints atomically before the WOW64 loader
hardens .text page protection. Use instead of launch() + set_breakpoint() when
setting breakpoints at process start."""
return client.call("launch_with_breakpoints",
{"path": path, "cwd": cwd, "breakpoints": breakpoints})
@mcp.tool()
def set_breakpoint(addr: str, condition: dict | None = None) -> dict:
return client.call("set_breakpoint", {"addr": addr, "condition": condition})
@mcp.tool()
def remove_breakpoint(addr: str) -> dict:
return client.call("remove_breakpoint", {"addr": addr})
@mcp.tool()
def list_breakpoints() -> dict:
return client.call("list_breakpoints", {})
@mcp.tool()
def set_watchpoint(addr: str, size: int, mode: str) -> dict:
return client.call("set_watchpoint", {"addr": addr, "size": size, "mode": mode})
@mcp.tool()
def remove_watchpoint(slot: int) -> dict:
return client.call("remove_watchpoint", {"slot": slot})
@mcp.tool()
def list_watchpoints() -> dict:
return client.call("list_watchpoints", {})
@mcp.tool()
def continue_execution(timeout: float) -> dict:
return client.call("continue_execution", {"timeout": timeout})
@mcp.tool()
def read_memory(addr: str, length: int) -> dict:
return client.call("read_memory", {"addr": addr, "length": length})
@mcp.tool()
def write_memory(addr: str, data_base64: str) -> dict:
return client.call("write_memory", {"addr": addr, "data": data_base64})
@mcp.tool()
def get_registers() -> dict:
return client.call("get_registers", {})
@mcp.tool()
def screenshot() -> dict:
return client.call("screenshot", {})
@mcp.tool()
def get_status() -> dict:
return client.call("get_status", {})
return mcp
class _BearerAuthMiddleware:
"""Raw ASGI middleware that enforces `check_bearer_token` on every HTTP request
before it reaches the wrapped app. Non-HTTP scopes (e.g. "lifespan") pass through
untouched. This is the actual auth enforcement point for the running server --
the built-in `mcp.server.auth` OAuth stack is deliberately not used here (see the
module-level note above `build_mcp_server`)."""
def __init__(self, app, expected_token: str) -> None:
self._app = app
self._expected_token = expected_token
async def __call__(self, scope, receive, send) -> None:
if scope["type"] != "http":
await self._app(scope, receive, send)
return
header_value = None
for name, value in scope.get("headers", []):
if name.lower() == b"authorization":
header_value = value.decode("latin-1")
break
if not check_bearer_token(header_value, expected=self._expected_token):
response = PlainTextResponse("Unauthorized", status_code=401)
await response(scope, receive, send)
return
await self._app(scope, receive, send)
def build_asgi_app(server: FastMCP, token: str):
"""Wrap the FastMCP Streamable HTTP app with bearer-token enforcement. This is
what actually gets served -- see the __main__ block below."""
return _BearerAuthMiddleware(server.streamable_http_app(), expected_token=token)
if __name__ == "__main__":
import uvicorn
token = os.environ["HAVOC_MCP_TOKEN"] # required, no default -- fail loudly if unset
if not token:
raise ValueError("HAVOC_MCP_TOKEN must not be empty")
client = DebugAgentClient(host="127.0.0.1", port=47474)
server = build_mcp_server(client)
app = build_asgi_app(server, token)
# Bind 0.0.0.0 so the LAN can reach it.
uvicorn.run(app, host="0.0.0.0", port=8765)