Circuit-Forge/circuitforge-core
3
0
Fork 0
Code Issues 6 Pull requests Projects Releases 5 Packages Wiki Activity Actions

feat: re-export make_feedback_router from circuitforge_core.api (closes #30) #32

Merged
pyr0ball merged 1 commit from feature/api-exports into main 2026-04-05 21:37:33 -07:00
Conversation 0 Commits 1 Files changed 1 +3
pyr0ball commented 2026-04-05 21:26:37 -07:00
Owner
Copy link

Summary\n\n- circuitforge_core/api/__init__.py now re-exports make_feedback_router\n- Consumers (kiwi, snipe, peregrine) updated to import from circuitforge_core.api instead of circuitforge_core.api.feedback\n- Consumer test mock paths unchanged (still target circuitforge_core.api.feedback.requests.* — the implementation location)\n\n## Test plan\n\n- [ ] conda run -n cf python -m pytest tests/api/test_feedback.py -q in kiwi — 7/7 pass\n- [ ] conda run -n cf python -m pytest tests/test_feedback.py -q in snipe — 7/7 pass\n- [ ] conda run -n cf python -m pytest tests/test_dev_api_feedback.py -q in peregrine — 7/7 pass\n- [ ] from circuitforge_core.api import make_feedback_router works after merge

## Summary\n\n- `circuitforge_core/api/__init__.py` now re-exports `make_feedback_router`\n- Consumers (kiwi, snipe, peregrine) updated to import from `circuitforge_core.api` instead of `circuitforge_core.api.feedback`\n- Consumer test mock paths unchanged (still target `circuitforge_core.api.feedback.requests.*` — the implementation location)\n\n## Test plan\n\n- [ ] `conda run -n cf python -m pytest tests/api/test_feedback.py -q` in kiwi — 7/7 pass\n- [ ] `conda run -n cf python -m pytest tests/test_feedback.py -q` in snipe — 7/7 pass\n- [ ] `conda run -n cf python -m pytest tests/test_dev_api_feedback.py -q` in peregrine — 7/7 pass\n- [ ] `from circuitforge_core.api import make_feedback_router` works after merge
pyr0ball added 1 commit 2026-04-05 21:26:38 -07:00
feat: re-export make_feedback_router from circuitforge_core.api (closes #30)
Some checks failed
CI / test (pull_request) Has been cancelled
Details
3c9c765668
pyr0ball merged commit 19a26e02a0 into main 2026-04-05 21:37:33 -07:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
architecture

   
backlog

   
enhancement

   
module:documents

   
module:hardware

   
module:manage

   
module:pipeline

   
module:voice

cf_voice module

  
priority:backlog

   
priority:high

   
priority:medium
No labels
architecture
backlog
enhancement
module:documents
module:hardware
module:manage
module:pipeline
module:voice
priority:backlog
priority:high
priority:medium
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Circuit-Forge/circuitforge-core#32
No description provided.
Delete branch "feature/api-exports"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?